Change in ovirt-engine[master]: core: standardize asserts
Allon Mureinik has submitted this change and it was merged.
Change subject: core: standardize asserts
......................................................................
core: standardize asserts
Standardized the asserts in StorageDomainToPoolRelationValidatorTest to
use assertThat with matchers from ValidationResultMatchers. This allows
us to reduce code bloating (e.g., checking a validation twice - once to
make sure it failed and then to verify the error message, having the
same assertion message over and over, etc.).
Change-Id: I2e2901dc8581ccabc28819e87c4e82bc3bbe412c
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/storage/StorageDomainToPoolRelationValidatorTest.java
1 file changed, 20 insertions(+), 45 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Jenkins CI: Passed CI tests
Amit Aviram: Looks good to me, but someone else must approve
Allon Mureinik: Verified
--
To view, visit https://gerrit.ovirt.org/43605
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e2901dc8581ccabc28819e87c4e82bc3bbe412c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org