Change in ovirt-engine[master]: userportal: NPE when there is no Blank template
Gilad Chaplik has submitted this change and it was merged.
Change subject: userportal: NPE when there is no Blank template
......................................................................
userportal: NPE when there is no Blank template
The problem was, that the it was expected, that
there has to be always a blank template. If there
was not, an empty instance of VmTemplate has been
added to the list of templates which could cause
NPEs.
Solved by adding the blank template to the beginning
of the list only if it is defined (in AsyncDataProvider
and UserPortalNewVmModelBehavior).
The corresponding method from DataProvider has been deleted
as it was never used (and is synchronous which has
no meaning in GWT world)
Change-Id: Ib7ae99cfb3bd663b6fdce373501bed98152b8b6d
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UserPortalNewVmModelBehavior.java
3 files changed, 30 insertions(+), 98 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5018
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib7ae99cfb3bd663b6fdce373501bed98152b8b6d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>