Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix localization issue in edit quota ...................................................................... webadmin: Fix localization issue in edit quota Edit Quota popup view had some hard coded strings which are imposible to localize to some languages. The string origin in the ApplicationConstants so they could not be formated. The issue was also relevant to SubTabQuotaClusterView and SubTabQuotaStorageView and was fix in those classes as well. New formated strings added to ApplicationMessages and the hard coded part was replaced with a message formating. This fix also handles a second localization issue in the EditQuotaClusterPopupView. The "vCpus" label was moved from EditQuotaClusterPopupView.ui.xml to ApplicationConstants to allow localization. Change-Id: I73146871d6ca7a8f91a190816df2c2dc684d9f5e Bug-Url: https://bugzilla.redhat.com/871042 Signed-off-by: Ofri Masad <omasad@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/EditQuotaClusterPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java 6 files changed, 66 insertions(+), 45 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73146871d6ca7a8f91a190816df2c2dc684d9f5e Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik@redhat.com> Gerrit-Reviewer: ofri masad <omasad@redhat.com>