From Daniel Erez <derez@redhat.com>:
Daniel Erez has submitted this change and it was merged. Change subject: core: avoid unlocking in-preview snapshot on failure ...................................................................... core: avoid unlocking in-preview snapshot on failure Failure during RestoreAllSnapshotsCommand execution unlocks the 'In Preview' snapshot while keeping the 'Active VM before the preview' snapshot. This allows previewing the snapshot again, thus, making another 'preview' snapshot and a lot of mess. The suggested solution is to simply avoid unlocking the snapshot on endWithFailure. Since the current logic exists from 2013 and seems invalid now, I'm open for any other suggestions :) Change-Id: I94c0b30b7621b8831f13815b3fdd8cdbce0117b7 Bug-Url: https://bugzilla.redhat.com/1427104 Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/RestoreAllSnapshotsCommand.java 1 file changed, 6 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/74093 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94c0b30b7621b8831f13815b3fdd8cdbce0117b7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>