Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Maximum number of VMs per user in VM Pool dialog validated
......................................................................
webadmin: Maximum number of VMs per user in VM Pool dialog validated
The problem was that validation of 'Maximum number of VMs per user'
field in both 'New pool' and 'Edit pool' dialog was simple interval
[1, 32767]. So it was possible to set Max num of VMs per user higher
than total number of available VMs in pool.
Now the upper bound of Max num of VMs per user is total number of VMs
in pool. Fixed in PoolModelBehaviorBase#validate(),
CommonApplicationMessages#maxAssignedVmsPerUserHelp()
Change-Id: Ic70d45b5e8d84965691777430f8f362a68bd4830
Bug-Url:
https://bugzilla.redhat.com/1124360
Signed-off-by: Jakub Niedermertl <jniederm(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
2 files changed, 3 insertions(+), 2 deletions(-)
Approvals:
Tomas Jelinek: Looks good to me, approved
Jakub Niedermertl: Verified
--
To view, visit
http://gerrit.ovirt.org/34581
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic70d45b5e8d84965691777430f8f362a68bd4830
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server