From Maor Lipchuk <mlipchuk(a)redhat.com>:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix validation for running VMs on amend.
......................................................................
core: Fix validation for running VMs on amend.
Avoid the use of private class member vmsForDisk in AmendImageGroupVolumesCommand.
The validation in the validate part should also use or instead of and.
If disk does not exists or a disk is attached to a running VM the
operation should fail.
Change-Id: Ied05826875b1019be42c13197b0d30a9c4f2024f
Bug-Url:
https://bugzilla.redhat.com/1448905
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/AmendImageGroupVolumesCommand.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Allon Mureinik: Looks good to me, but someone else must approve
Maor Lipchuk: Verified
Liron Aravot: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/76815
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ied05826875b1019be42c13197b0d30a9c4f2024f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>