Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Don't require admin/filter to access root service
......................................................................
restapi: Don't require admin/filter to access root service
Currently access to the root service requires admin privileges or the
use of the "Filter" header. If a non privileged users tries to use this
service without the "Filter" header an error is returned because some of
the queries that it uses fail. To avoid that this patch changes the
implementation of this service so that it will explicitly check the
result of the queries. If a query fails the corresponding data won't be
added to the returned result, but the overall request will succeed.
Change-Id: I6b8582238dede59724277795c32640ee1bef808f
Bug-Url:
https://bugzilla.redhat.com/1323631
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResource.java
M
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendResource.java
3 files changed, 144 insertions(+), 113 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit
https://gerrit.ovirt.org/57275
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b8582238dede59724277795c32640ee1bef808f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>