From Liron Aravot <laravot@redhat.com>:
Liron Aravot has submitted this change and it was merged. Change subject: core: adding first_metadata_device to storage domain static ...................................................................... core: adding first_metadata_device to storage domain static We added a support to VDSM to report the device of the first extant of the domain metadata lv. VDSM relies on the fact that the metadata lv first extant is always 0 - therefore we should block operations for being done on that device. For example, attempt to move the data from that device might change the first extant of the metadata lv to something different than 0 - making the domaun unusable. While VDSM code has validation to prevent such operations from being performed, we should have that information on the engine side to provide better user experience by blocking attempts to send such requests. NOTE: The metadata LV might be extended to reside on more devices, the column saves the device of the first extant of the lv. Change-Id: I54e35f7cb3b51725c219f625a3d3434575d66113 Signed-off-by: Liron Aravot <laravot@redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomain.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainStaticDaoImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainStaticDaoTest.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageServerConnectionLunMapDaoTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java M packaging/dbscripts/create_views.sql M packaging/dbscripts/storages_sp.sql A packaging/dbscripts/upgrade/04_01_0430_add_first_metadata_device_col_to_storage_domain_static.sql 13 files changed, 92 insertions(+), 2 deletions(-) Approvals: Liron Aravot: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I54e35f7cb3b51725c219f625a3d3434575d66113 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Ala Hino <ahino@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>