From Allon Mureinik <amureini@redhat.com>:
Allon Mureinik has submitted this change and it was merged. Change subject: core: GetManagementNetworkCandidatesQuery filtering ...................................................................... core: GetManagementNetworkCandidatesQuery filtering GetManagementNetworkCandidatesQuery's is when setting up the management network, which is an administrative action, and is indeed only ever called by the webadmin. As such, the filtering parameters are never passed to it, and should be removed from the query's code, as they just cause confusion. Change-Id: I4ef4add9149701d4be307ebdf97e4f2eec9dcef1 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/dc/GetManagementNetworkCandidatesQueryTest.java 2 files changed, 2 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/66287 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ef4add9149701d4be307ebdf97e4f2eec9dcef1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmucha@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1976@gmail.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>