Allon Mureinik has submitted this change and it was merged. Change subject: core: Reuse VersionRowMapper ...................................................................... core: Reuse VersionRowMapper Reuse VersionRowMapper to parse versions instead of reimplementing the same logic over and over. Change-Id: I31dc1b58a3245bed4ad436fc7b9f37e13a01178f Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ClusterFeatureDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StoragePoolDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/UnregisteredOVFDataDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VersionRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmBaseDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/NetworkViewDaoImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VnicProfileViewDaoImpl.java 11 files changed, 14 insertions(+), 22 deletions(-) Approvals: Martin Peřina: Looks good to me, approved Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/63164 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31dc1b58a3245bed4ad436fc7b9f37e13a01178f Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>