Oved Ourfali has submitted this change and it was merged. Change subject: api: Fix approve API to allow deploy with public key ...................................................................... api: Fix approve API to allow deploy with public key Currently we don't set the authentication method and engine searches for password validation. Approve API should use PK auth as default except password and authentication method are set. (Apperently approve call by API was never tested and currently fails on "empty password") Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1101565 Change-Id: I9816d907d45ec7b4ee066fa369ca1150e688084f Signed-off-by: Yaniv Bronhaim <ybronhei@redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java 2 files changed, 26 insertions(+), 2 deletions(-) Approvals: Amador Pahim: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/27622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9816d907d45ec7b4ee066fa369ca1150e688084f Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Amador Pahim <apahim@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ori Liel <oliel@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybronhei@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server