Change in ovirt-engine[master]: scheduler: Fix migration free cluster detection
Roy Golan has submitted this change and it was merged.
Change subject: scheduler: Fix migration free cluster detection
......................................................................
scheduler: Fix migration free cluster detection
Accidently the VdsId was used where the VdsGroupId should have been
used. This change directly queries for all VdsGroups where no VM is currently migrating.
- Remove getAllByStatus() from VmDynamicDao
- Add VdsGroupDao#getWithoutMigratingVms and use it in AREM
Bug-Url: https://bugzilla.redhat.com/1251742
Change-Id: Ib2d3383750babf1d1f295d423939bb1fa03e5bee
Signed-off-by: Roman Mohr <rmohr(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManager.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/scheduling/AffinityRulesEnforcementManagerTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDaoImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDaoImpl.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDaoTest.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDaoTest.java
M packaging/dbscripts/vds_groups_sp.sql
M packaging/dbscripts/vms_sp.sql
10 files changed, 62 insertions(+), 89 deletions(-)
Approvals:
Roman Mohr: Verified
Jenkins CI: Passed CI tests
Tomer Saban: Looks good to me, but someone else must approve
Roy Golan: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/45876
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2d3383750babf1d1f295d423939bb1fa03e5bee
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Roman Mohr <rmohr(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tomer Saban <tsaban(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org