Einav Cohen has submitted this change and it was merged.
Change subject: userportal: Optimization fixes
......................................................................
userportal: Optimization fixes
1. Fixed a problem when Basic view item selection
was not retained after subsequent data refresh
2. Fixed a problem when Basic view UI was redrawn
even when there was no change in items
3. Removed duplicate code with regard to clearing
UserPortalItemModel references by moving it to
IUserPortalListModel (parent class)
4. Fixed issue where if nothing changed the buttons
would become disabled.
5. Fixed issue where buttons in basic/extended tab
were unresponsive.
Change-Id: I81b30a5e03d35862d92e6630aac71c70f7cd75de
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalBasicListModel.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/AbstractUserPortalListProvider.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/UserPortalDataBoundModelProvider.java
4 files changed, 21 insertions(+), 19 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/12213
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I81b30a5e03d35862d92e6630aac71c70f7cd75de
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>