Change in ovirt-engine[ovirt-engine-3.5.3]: core: Extracting virtIO-scsi disabling check in CDA
Tal Nisan has submitted this change and it was merged.
Change subject: core: Extracting virtIO-scsi disabling check in CDA
......................................................................
core: Extracting virtIO-scsi disabling check in CDA
VirtIO-scsi disabling validation in AddVmFromSnapshotCommand's CDA is
extracted to an outer function for Simplification of the code. This
enables a significant ease in unit-testing AddVmFromSnapshotCommand's
functionality.
Change-Id: Ic581f078b071b029444c699f08c7de8e87518723
Bug-Url: https://bugzilla.redhat.com/1220282
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommandTest.java
2 files changed, 14 insertions(+), 4 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Amit Aviram: Verified
--
To view, visit https://gerrit.ovirt.org/40752
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic581f078b071b029444c699f08c7de8e87518723
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.3
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org