Change in ovirt-engine[master]: core: Reorganize SD space validations in AddVm
Allon Mureinik has submitted this change and it was merged.
Change subject: core: Reorganize SD space validations in AddVm
......................................................................
core: Reorganize SD space validations in AddVm
This is the first of two patches meant to fix faulty storage space
allocations validations in the different add VM commands.
This patch keeps the current (faulty) validations and reorganizes them
in methods that can be overridden in the derived classes when needed.
It also adds two new threshold tests - verifying the AddVmCommand
behaviour to the simulated
StorageDomainValidator.isDomainWithinThresholds .
Change-Id: I482709d7edb0333a6aa7b9ab723eea7f4c5a00d3
Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=917682
Related-to: https://bugzilla.redhat.com/show_bug.cgi?id=1053742
Signed-off-by: Vered Volansky <vvolansk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
2 files changed, 103 insertions(+), 26 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/26733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I482709d7edb0333a6aa7b9ab723eea7f4c5a00d3
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server