Change in ovirt-engine[master]: engine: Validate Dup MAC Addresses upon Iface Plug
Muli Salem has submitted this change and it was merged.
Change subject: engine: Validate Dup MAC Addresses upon Iface Plug
......................................................................
engine: Validate Dup MAC Addresses upon Iface Plug
This patch validates that there are no plugged network interfaces
with the same MAC address as the network interface that
is being plugged.
This validation is needed, since when importing or taking a
snapshot of VM with a network interface that has a duplicate
MAC address, we unplug the network interface and do not fail
the action.
Change-Id: If1476e8bec112c0c592e5cc16deefcf67076f5dc
Bug-Url: https://bugzilla.redhat.com/873338
Signed-off-by: Muli Salem <msalem(a)redhat.com>
---
M backend/manager/dbscripts/network_sp.sql
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDao.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoDbFacadeImpl.java
M
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/network/VmNetworkInterfaceDaoTest.java
6 files changed, 69 insertions(+), 1 deletion(-)
Approvals:
Muli Salem: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12242
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1476e8bec112c0c592e5cc16deefcf67076f5dc
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msalem(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>