Omer Frenkel has submitted this change and it was merged.
Change subject: core: rerun HA vm that fails during live snapshot
......................................................................
core: rerun HA vm that fails during live snapshot
This patch fix a bug that happens when HA vm fails during live
snapshot operation, and stays down.
The problem was that when the monitoring detected that the vm is dowm,
it tried to rerun it, but the RunVm command failed because the vm was
during snapshot.
The solution is to save the VM status when starting to execute the
CreateAllSnapshots command, and at the end check if the VM is HA +
it's down because of an error + it wasn't down when the command
started - that would mean the VM went down unexpectedly during the
snapshot command, and thus will try to run it.
Change-Id: Id5daeffd1cee106019065c29fb8428a9b9f78a5d
Bug-Url:
https://bugzilla.redhat.com/878041
Signed-off-by: Arik Hadas <ahadas(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
4 files changed, 83 insertions(+), 29 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Arik Hadas: Verified
--
To view, visit
http://gerrit.ovirt.org/10618
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5daeffd1cee106019065c29fb8428a9b9f78a5d
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>