2:05 p.m.
Allon Mureinik has submitted this change and it was merged.
Change subject: engine: Upgrade Checkstyle to 6.8
......................................................................
engine: Upgrade Checkstyle to 6.8
Upgrading checkstyle to 6.8 in order to consume checkstyle fixes.
This patch includes:
1. Fixing checkstyle violations missed by the old version of
checkstyle (presumably due to bugs in checkstyle).
2. Extract the checkstyle.version variable in the pom.xml files and
unify the references to checkstyle's version. Note that this change
fixes a discrepancy between the version we build our extensions on
(5.4) and the runtime version used to check the build (6.5).
3. Upgrade the aforementioned checkstyle version to a newer version,
6.8.
4. Remove the unused import of
com.puppycrawl.tools.checkstyle.api.AnnotationUtility in
NoMemberInitializationCheck. This class was moved in checkstyle 6.8,
and was breaking the build.
5. Change the import of
com.puppycrawl.tools.checkstyle.api.ScopeUtils to
com.puppycrawl.tools.checkstyle.ScopeUtils in
NoMemberInitializationCheck to reflect the location this class was
moved to in checkstyle 6.8.
Change-Id: I11f3499df2aba2c43fe2b5acef8ca97a3ec7cc2d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/domain/GetStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/BatchProcedureExecutionConnectionCallback.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterDBUtils.java
M
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/ADSyntaxChecker.java
M build-tools-root/ovirt-checkstyle-extension/pom.xml
M
build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoArgConstructorCheck.java
M
build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NoMemberInitializationCheck.java
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/RegistrationResult.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/extended/vm/SubTabExtendedVmGuestInfoPresenter.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java
M pom.xml
16 files changed, 17 insertions(+), 31 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/49489
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I11f3499df2aba2c43fe2b5acef8ca97a3ec7cc2d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>