Alona Kaplan has submitted this change and it was merged. Change subject: engine: Passing to ActivateDeactivateVnic the vnic ...................................................................... engine: Passing to ActivateDeactivateVnic the vnic As ActivateDeactivateVmInterface became an internal command it shouldn't get the vnic from the db. The command that called the ActivateDeavtivate have already got the vnic and can pass it. In case the caller command is UpdateVmInterface and the action is unplug, the passed nic should be the old nic (the host is familiar to) and not the updated one. Change-Id: I058b7197ec5a152e91cbb3c362b290326678df40 Bug-Url: https://bugzilla.redhat.com/904840 Signed-off-by: Alona Kaplan <alkaplan@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AbstractVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/vm/UpdateVmInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ActivateDeactivateVmNicParameters.java 5 files changed, 24 insertions(+), 44 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/12792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I058b7197ec5a152e91cbb3c362b290326678df40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni@redhat.com> Gerrit-Reviewer: Moti Asayag <masayag@redhat.com>