Change in ovirt-engine[master]: core:Hot Plug Nic/Disk creates incorre...(#855651)
Eli Mesika has submitted this change and it was merged.
Change subject: core:Hot Plug Nic/Disk creates incorre...(#855651)
......................................................................
core:Hot Plug Nic/Disk creates incorre...(#855651)
core:Hot Plug Nic/Disk creates incorrect duplicate devices
https://bugzilla.redhat.com/show_bug.cgi?id=855651
The Hot Plug Nic/Disk commands does not set the deviceId field.
When we get run time info from VDSM, we are looking for the deviceId
field, it is is not found, the device is assumed to be an unmanaged
device reported to us as a new device by VDSM (i.e. does not exists in
DB yet)
This will result in a duplicate of each Nic/Disk that is marked as
managed device with another device (with different GUID) in vm_device that
is marked as an unmanaged device while the last (and incorrect device)
will get the address and alias field updates.
This patch sets the deviceId field in Nic/Disk Hot Plug command, since this
field is not touched by VDSM and returned as is, we can match the
returned hot-plug device when updates arrived with current hot plug
devices and update the information instead adding new devices.
Change-Id: Idac67477c800339b0c48f86a3281c90f3fd4ed7b
Signed-off-by: Eli Mesika <emesika(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugDiskVDSCommand.java
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HotPlugNicVDSCommand.java
2 files changed, 2 insertions(+), 0 deletions(-)
Approvals:
Eli Mesika: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7881
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idac67477c800339b0c48f86a3281c90f3fd4ed7b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>