Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network Import dialog open/cancel fails ...................................................................... webadmin: Network Import dialog open/cancel fails The Network Import dialog in the network list fails to close when cancel is pressed. It also opens only once, all further attempts to open it fail. The issue was caused by an incorrect model being injected into the model (the external provider one). The same dialog is also used in external providers network import. There it works fine, as the model is the right one. Change-Id: Id6a687c0c290891b3c5636dc82d598399f3e37df Bug-Url: https://bugzilla.redhat.com/1306585 Signed-off-by: mirecki <mmirecki@redhat.com> --- A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/BaseImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/ImportNetworksModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/providers/DiscoverNetworksModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/provider/ImportNetworksPopupPresenterWidget.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/provider/ImportNetworksPopupView.java 5 files changed, 375 insertions(+), 364 deletions(-) Approvals: Marcin Mirecki: Verified Alona Kaplan: Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/53479 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6a687c0c290891b3c5636dc82d598399f3e37df Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Marcin Mirecki <mmirecki@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki <mmirecki@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>