Barak Azulay has submitted this change and it was merged.
Change subject: Adding Unit Tests and Functional Tests
......................................................................
Adding Unit Tests and Functional Tests
The functional tests so far are testing the retrieval
of data from the underlying system and ensures the structure
of the data. It does not however validate the content.
It ensures that the messages sent over the VirtIO Serial
channel have the format defined.
If we change the format it will break the unit tests.
Additionally a check for the unicode filtering.
Change-Id: I4c1d740c948e33aed8a04a1013b22276cf7d85e3
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
---
M Makefile.am
M configure.ac
M ovirt-guest-agent/VirtIoChannel.py
A tests/Makefile.am
A tests/encoding_test.py
A tests/guest_agent_test.py
A tests/message_validator.py
A tests/test_port.py
A tests/testrunner.py
A tests/unittest.bat
10 files changed, 491 insertions(+), 12 deletions(-)
Approvals:
Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve
Barak Azulay: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/19052
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c1d740c948e33aed8a04a1013b22276cf7d85e3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>