Change in ovirt-engine[master]: core: RunVmCommandTest: Set instead of spying
Allon Mureinik has submitted this change and it was merged.
Change subject: core: RunVmCommandTest: Set instead of spying
......................................................................
core: RunVmCommandTest: Set instead of spying
Use the conventional setter instead of spying wherever possible.
This approach has three main advantages:
1. It's easier to read and understand and thus, maintain.
2. It's a tad faster
3. It uses actual production code, thus [slightly] increasing the test
coverage.
Change-Id: Ia1fcde6e12eb1b2e9987521e04314066384a25ee
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java
M
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
2 files changed, 22 insertions(+), 32 deletions(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/65190
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1fcde6e12eb1b2e9987521e04314066384a25ee
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>