Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Slightly amend checkbox header logic ...................................................................... webadmin: Slightly amend checkbox header logic Previously the logic only relied on enabled entries to determine whether the checkbox header should be checked or not, however this produced inconsistent results when all entries are disabled. Special attention is now paid to that case. Also, the logic for determining whether an entry is enabled seemed to be out-of-date and wasn't functioning properly. Change-Id: I2e7786d55c0f639c0e2f4af4685d125462724175 Bug-Url: https://bugzilla.redhat.com/1100292 Signed-off-by: Lior Vernia <lvernia@redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/31596 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e7786d55c0f639c0e2f4af4685d125462724175 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan@redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia@redhat.com> Gerrit-Reviewer: automation@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server