Ondra Machacek has submitted this change and it was merged. Change subject: Fix tag names of action parameters ...................................................................... Fix tag names of action parameters Currently when the SDK generates the XML document to invoke an action method it assumes that the names of the elements inside the 'action' match the names of the types of the parameters. This isn't correct, they should match the names of the parameters, not the names of the types. For example, the 'Host.iscsi_discover' action method has a parameter of type 'IscsiDetails' and name 'iscsi', so the tag should be 'iscsi', not 'iscsi_details'. To solve this issue this patch chages the SDK so that the implementation of action methods create an instance of the 'Action' type, and render it uusing the 'ActionWriter' class, which knows how to write it correctly. Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> --- M generator/src/main/java/org/ovirt/sdk/python/ServicesGenerator.java 1 file changed, 11 insertions(+), 52 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/63189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc05fc5791d6d8ecd2e6c22a6c1aaab96a843b98 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>