Omer Frenkel has submitted this change and it was merged.
Change subject: core: Remove VM pool if no VMs can be created
......................................................................
core: Remove VM pool if no VMs can be created
If VM pool is created via REST API and one of VM parameters is
incorrect, the VM Pool is created, but VM creation fails. In this case
VM pool is also removed, because VM pool without VMs shouldn't exist.
Change-Id: I36b137a905ea1364255af2bcdb11b27ed5198342
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1202129
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmPoolWithVmsCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
3 files changed, 24 insertions(+), 2 deletions(-)
Approvals:
Shmuel Leib Melamud: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit
https://gerrit.ovirt.org/39336
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I36b137a905ea1364255af2bcdb11b27ed5198342
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server