Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: add enable SPICE proxy checkbox
......................................................................
userportal,webadmin: add enable SPICE proxy checkbox
Added a new checkbox under SPICE options of the console
popup window named "Enable SPICE Proxy".
The behavior:
- if the SPICE proxy is configured on system level (SpiceProxyDefault)
+ the "Enable SPICE Proxy" checkbox is enabled and checked by default
+ if the selection is changed, than it is stored in the brower level
- if the SPICE proxy is NOT configured on system level (SpiceProxyDefault):
+ the "Enable SPICE Proxy" is not editable and has a title:
"No SPICE proxy defined on system level"
+ it is not checked
+ if it was previously checked and this preference stored on browser level,
this preference is ignored and the checkbox will be unchecked
Change-Id: I879a4976c649f1d568f42c2d72f9e995a618d874
Bug-Url:
https://bugzilla.redhat.com/924605
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ConsolePopupPresenterWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/AbstractSpice.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleOptionsFrontendPersisterImpl.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ConsoleUtils.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/ConsolePopupView.ui.xml
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java
11 files changed, 86 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/13328
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I879a4976c649f1d568f42c2d72f9e995a618d874
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkobzik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>