Change in ovirt-engine[master]: engine: Enforce maximal QoS commitment on interface
Lior Vernia has submitted this change and it was merged.
Change subject: engine: Enforce maximal QoS commitment on interface
......................................................................
engine: Enforce maximal QoS commitment on interface
Made sure that no more than 75% of a an interface's capacity can be
committed by QoS, as overcommitment may lead to unexpected and
potentially destructive behavior.
As part of this validation, also made sure all interface speeds are
either reported by vdsm or can be computed in the engine
(newly-created bonds); otherwise fail, as we cannot guarantee that the
user hasn't over-committed.
Change-Id: Icc89f4193d6b7b590c6e1e053af74ab23bc77a11
Signed-off-by: Lior Vernia <lvernia(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelper.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/host/SetupNetworksHelperTest.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkInterface.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
7 files changed, 383 insertions(+), 24 deletions(-)
Approvals:
Lior Vernia: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/34133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc89f4193d6b7b590c6e1e053af74ab23bc77a11
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Martin Mucha <mmucha(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server