Change in ovirt-engine[master]: core: UpdateStoragePoolCommand refactoring.
Tal Nisan has submitted this change and it was merged.
Change subject: core: UpdateStoragePoolCommand refactoring.
......................................................................
core: UpdateStoragePoolCommand refactoring.
UpdateStoragePoolCommand's CDA was refactored to fit the CDA style in
the system. as a side effect this makes the code a bit more efficient
since once a validation fails within the CDA it makes the function
return and not continue to the next validation.
Change-Id: Icd0c28eb86af753a7e48e845da23fc5feca2019a
Signed-off-by: Amit Aviram <aaviram(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
M
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java
2 files changed, 24 insertions(+), 29 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Amit Aviram: Verified
Allon Mureinik: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/35788
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd0c28eb86af753a7e48e845da23fc5feca2019a
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server