Change in ovirt-engine[ovirt-engine-3.6]: engine : Can't remove vm template - the disks are removed an...
Tal Nisan has submitted this change and it was merged.
Change subject: engine : Can't remove vm template - the disks are removed and the
template stays locked
......................................................................
engine : Can't remove vm template - the disks are removed and the template stays
locked
The patch Ib3261800f383a6e3973acab4bd1 caused regression
in commands that ran Async Tasks.
This patch reverts the changes in CommandBase related to
AsyncTasks and implements a simpler solution using
existing shouldBeEndedByParent flag in VdcActionParametersBase.
Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667
Bug-Url: https://bugzilla.redhat.com/1293644
Signed-off-by: Ravi Nori <rnori(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CoCoAsyncTaskHelper.java
2 files changed, 16 insertions(+), 81 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Daniel Erez: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/50911
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41f318c8fbef94d3d125d2ca80d687cb27195667
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>