Tal Nisan has submitted this change and it was merged. Change subject: restapi: Avoid NPE in QoS mapper ...................................................................... restapi: Avoid NPE in QoS mapper The mapper is used also when processing an update, and in that case the "type" can be empty, thus triggering an exception when calling "toLowerCase". This patch moves the conversion to lower case to the place where it is actually needed, and where we know that the value won't be null. Change-Id: I31ee09a1eb1cd9a706a88fe836b04dfa404841a5 Bug-Url: https://bugzilla.redhat.com/1274187 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com> (cherry picked from commit 86bc666f8784a2223ff80f728648166878a9dd67) --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/QosTypeMapper.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/47679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I31ee09a1eb1cd9a706a88fe836b04dfa404841a5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.6 Gerrit-Owner: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: automation@ovirt.org