Change in ovirt-engine[master]: core: 'No Network' on a Vnic should be marked as null and no...
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: 'No Network' on a Vnic should be marked as null and not
empty String.
......................................................................
core: 'No Network' on a Vnic should be marked as null and not empty String.
If on importVm, the VM has Nics with non valid Network, the Network
was deleted by setting it to empty String.
Since NetworkLinking feature, the convention is to mark no-network as null
and not as empty String.
Change-Id: Ia802fc81be7d65d3f4039e757646918aae5dc0a3
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
A
backend/manager/dbscripts/upgrade/03_02_0140_allow_null_network_name_in_vm_interfaces.sql
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
3 files changed, 8 insertions(+), 3 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9563
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia802fc81be7d65d3f4039e757646918aae5dc0a3
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>