Itamar Heim has submitted this change and it was merged. Change subject: restapi: del storage conn if domain creation fails ...................................................................... restapi: del storage conn if domain creation fails Delete storage connection if storage domain creation fails in order not to leave leftovers in db from a failed operation. Note - the connection will be deleted only if it was created as part of the domain creation call. If it was created in the past and just reused with its connection id in the domain creation call, then it will not be deleted. Change-Id: I71c689ccdbcd038d1b92629b3e46691be0885321 Bug-Url: https://bugzilla.redhat.com/991470 Signed-off-by: Alissa Bonas <abonas@redhat.com> Signed-off-by: Daniel Erez <derez@redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainsResourceTest.java 2 files changed, 26 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Looks good to me, approved Daniel Erez: Verified Allon Mureinik: Looks good to me, but someone else must approve Alissa Bonas: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/23545 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71c689ccdbcd038d1b92629b3e46691be0885321 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Itamar Heim <iheim@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server