Change in ovirt-engine[master]: core : duplicate HDD name during creating new HDD (#769885)
Michael Kublin has submitted this change and it was merged.
Change subject: core : duplicate HDD name during creating new HDD (#769885)
......................................................................
core : duplicate HDD name during creating new HDD (#769885)
https://bugzilla.redhat.com/769885
The following bug was caused because of race inside lock of vm process,
from now there are no need for uniqnes of hdd names and also no need to lock vm when
we are adding a disk.
A patch contains the following:
1. Removed lock from vm
2. Adding compenstaion at AddDiskToVmCommand
3. Fixing bug with compensation at AddDiskCommand
4. Using a new lock mechanism fixing races
Change-Id: Ic4dbf9c451205b8c3a4c3510661a5d410c9a8195
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddImageFromScratchCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java
5 files changed, 110 insertions(+), 80 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5024
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4dbf9c451205b8c3a4c3510661a5d410c9a8195
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>