Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove MoveVmCommand ...................................................................... core: Remove MoveVmCommand oVirt 3.0 had a command to move a VM from one storage domain to another. oVirt 3.1 introduced the notion of a VM having multiple disks on multiple storage domains, with the ability to move them independently, rendering this command meaningless, and it was indeed marked as deprecated and preserved only in order to not break the REST API's backwards compatibility. Change I8953fe1c6c68e5bc95662342c8193fa77a1019d3 removed this broken API call, and this patch finishes the job be removing the backend code that used to support it With the removal of MoveVMCommand, MoveOrCopyTemplateCommand#getMoveOrCopyImageOperation() will always return ImageOperation.Copy, so any code referencing ImageOperation.Move in this hierarchy was also removed. Change-Id: I2a738a78d9f5f7f3812e3f8443c9a49c3d012daa Bug-Url: https://bugzilla.redhat.com/1320515 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/export/MoveOrCopyTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/EngineMessage.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties M backend/manager/modules/restapi/README.adoc M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties A packaging/dbscripts/upgrade/04_00_0390_delete_move_vm_auditlog.sql 18 files changed, 38 insertions(+), 297 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Eli Mesika: Looks good to me, but someone else must approve Allon Mureinik: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/55086 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a738a78d9f5f7f3812e3f8443c9a49c3d012daa Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Liron Aravot <laravot@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan@redhat.com> Gerrit-Reviewer: gerrit-hooks <automation@ovirt.org>