Piotr Kliczewski has submitted this change and it was merged.
Change subject: webadmin: Handle null and empty list values in
ListModelMultipleSelectListBox
......................................................................
webadmin: Handle null and empty list values in ListModelMultipleSelectListBox
The code assumed the values are always passed which isn't the case for
new clusters and that caused NPE in GWT and dialogs to appear stuck on
loading.
Change-Id: I77fd69736080eb253f0c3259bda6e3108a2493a2
Bug-Url:
https://bugzilla.redhat.com/1248509
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
(cherry picked from commit b697f2846a21027899202023b235c095f1333edb)
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/ListModelMultipleSelectListBox.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Alexander Wels: Looks good to me, approved
Jenkins CI: Passed CI tests
Roy Golan: Verified
--
To view, visit
https://gerrit.ovirt.org/44457
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77fd69736080eb253f0c3259bda6e3108a2493a2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.6
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org