Change in ovirt-engine[master]: webadmin, userportal: Fix CommonModel search string regressio...
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin,userportal: Fix CommonModel search string regression
......................................................................
webadmin,userportal: Fix CommonModel search string regression
Patch [58a8ec Element IDs in System Tree and Tags] introduced TreeNodeInfo
interface and made SystemTreeItemModel implement this interface to support
dealing with physical parent/child relationship within a System Tree node
hierarchy.
The above mentioned patch also corrected some physical parent/child
relationships (calls to setParent method) in SystemTreeModel.
However, some code in CommonModel relies on (logical) parent/child
relationships that were corrected in above mentioned patch, which causes
a regression in CommonModel for computing some search strings.
This patch fixes the above mentioned problem by using SystemTreeItemModel
findAncestor method, which traverses up the (physical) parent node
hierarchy to find the correct (logical) tree node, assuming the logical
node is always reachable from given physical node (by traversing up).
Change-Id: I79f2e9f18e08b89cdfe84d4657bce1de8f8988bb
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15086
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I79f2e9f18e08b89cdfe84d4657bce1de8f8988bb
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>