Change in ovirt-engine[master]: engine: Upper bound for VmPool.MaxAssignedVmsPerUser
Tomas Jelinek has submitted this change and it was merged.
Change subject: engine: Upper bound for VmPool.MaxAssignedVmsPerUser
......................................................................
engine: Upper bound for VmPool.MaxAssignedVmsPerUser
Added an upper bound to the VmPool.MaxAssignedVmsPerUser property of
32,767 to prevent integer overflows and the possibility to get VmPool
in incosistent state by submitting exceedingly large value reulting in
negative value being set.
Change-Id: I1877312f61eae608103d596c90bffc6e6c3fa8d9
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=988056
Signed-off-by: Martin Betak <mbetak(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationMessages.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 7 insertions(+), 5 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/17677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1877312f61eae608103d596c90bffc6e6c3fa8d9
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server