Change in ovirt-engine[master]: core: Check result of "Path.getFileName" in "VdsBrokerObject...
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Check result of "Path.getFileName" in
"VdsBrokerObjectsBuilder"
......................................................................
core: Check result of "Path.getFileName" in "VdsBrokerObjectsBuilder"
This is needed in order to avoid the following findbugs warning:
Possible null pointer dereference due to return value of called method
The return value from a method is dereferenced without a null check,
and the return value of that method is one that should generally be
checked for null. This may lead to a NullPointerException when the
code is executed.
Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
Change-Id: If2272ba1d2d50b85acfa4bbf6bd2db95f4d4c750
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
Martin Betak: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/46607
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2272ba1d2d50b85acfa4bbf6bd2db95f4d4c750
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Martin Betak <mbetak(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org