Roy Golan has submitted this change and it was merged. Change subject: core: is_inhertiable->allows_viewing_childern ...................................................................... core: is_inhertiable->allows_viewing_childern Renamed the is_inheritable property in the Role and ActionGroup MLA entities to the more accurate allows_viewing_children after some comments by rgolan on http://gerrit.ovirt.org/#change,4607. Change-Id: I3bc62635d0e294a5d91696d8e390ccfc6cb86f09 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/dbscripts/multi_level_administration_sp.sql A backend/manager/dbscripts/upgrade/03_01_1110_rename_inheritable_roles_columns.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/roles.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/RolesRowMapper.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/RoleDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/RoleDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml 8 files changed, 22 insertions(+), 20 deletions(-) Approvals: Allon Mureinik: Verified Roy Golan: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4695 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bc62635d0e294a5d91696d8e390ccfc6cb86f09 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel@redhat.com> Gerrit-Reviewer: Roy Golan <rgolan@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>