Change in ovirt-engine[master]: core: Check result of "listFiles" in "GetoVirtISOsQuery"
Juan Hernandez has submitted this change and it was merged.
Change subject: core: Check result of "listFiles" in
"GetoVirtISOsQuery"
......................................................................
core: Check result of "listFiles" in "GetoVirtISOsQuery"
This is needed in order to avoid the following findbus warning:
Possible null pointer dereference due to return value of called method
The return value from a method is dereferenced without a null check,
and the return value of that method is one that should generally be
checked for null. This may lead to a NullPointerException when the
code is executed.
Bug kind and pattern: NP - NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE
Change-Id: I1d5a7bafedbe4208d74f6dc824ddf853e870eb81
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/GetoVirtISOsQuery.java
1 file changed, 33 insertions(+), 30 deletions(-)
Approvals:
Douglas Schilling Landgraf: Looks good to me, but someone else must approve
Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests
--
To view, visit https://gerrit.ovirt.org/46574
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d5a7bafedbe4208d74f6dc824ddf853e870eb81
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org