Yair Zaslavsky has submitted this change and it was merged.
Change subject: tools: Add runtime log4j setup to engine-manage-domains
......................................................................
tools: Add runtime log4j setup to engine-manage-domains
1) Moves default log4j.xml for engine-manage-domains into tools.jar
2) By default logging is off
3) Adds --log-file which sets file to write logging messages into
4) Adds --log-level which sets logging level for logger specified
with --log-file (it's set to INFO by default)
5) Adds --log4j-config which sets filename or URL with custom
log4j.xml file to setup logging
Change-Id: I0641dd6ce8984504c8c6e97df7b90e81ca5a8c4f
Bug-Url:
https://bugzilla.redhat.com/1083411
Signed-off-by: Martin Perina <mperina(a)redhat.com>
---
M Makefile
M
backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomains.java
M
backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsArguments.java
A
backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/tools/ManageDomainsExecutor.java
A
backend/manager/modules/builtin-extensions/src/main/resources/engine-manage-domains/log4j.xml
M
backend/manager/modules/builtin-extensions/src/main/resources/manage-domains-help.properties
M ovirt-engine.spec.in
M packaging/bin/engine-manage-domains.sh
D packaging/etc/engine-manage-domains/log4j.xml.in
M packaging/man/man8/engine-manage-domains.8
10 files changed, 146 insertions(+), 91 deletions(-)
Approvals:
Martin Peřina: Verified
Yair Zaslavsky: Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/26641
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0641dd6ce8984504c8c6e97df7b90e81ca5a8c4f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server