Change in ovirt-engine[master]: backend: fix template's disk volume info
Tal Nisan has submitted this change and it was merged.
Change subject: backend: fix template's disk volume info
......................................................................
backend: fix template's disk volume info
Commit 92665e0af829d25273d5d45669847569eae6f5cc introduced the ability
to specify a template disk's format when creating it. However, if the
format was not specified, it defaulted to the active image's format.
This behavior, although not entirely a bad idea (as it prefers thin
provisioning over prealloaction, which may in fact be the best practice
for template disks), is inconsistent with previous versions' behavior,
and could be considered a behavioral regression.
This patch restores the original behavior of matching the template
disk's format with the format of the base image of the disk its derived
from, unless it's explicitly specified, of course.
Change-Id: I7a976c157eb0dbab4fd311a2ae60a57f6c88f4f0
Bug-Url: https://bugzilla.redhat.com/1257240
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Daniel Erez: Looks good to me, but someone else must approve
Jenkins CI: Passed CI tests
Arik Hadas: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit https://gerrit.ovirt.org/47475
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a976c157eb0dbab4fd311a2ae60a57f6c88f4f0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org