Change in ovirt-engine[master]: webadmin: Make ConsolesBase.modelTypeMapping private
Juan Hernandez has submitted this change and it was merged.
Change subject: webadmin: Make ConsolesBase.modelTypeMapping private
......................................................................
webadmin: Make ConsolesBase.modelTypeMapping private
This is a way to avoid the following findbugs warning:
Field is a mutable collection which should be package protected
A mutable collection instance is assigned to a final static field, thus
can be changed by malicious code or by accident from another package.
The field could be made package protected to avoid this vulnerability.
Alternatively you may wrap this field into
Collections.unmodifiableSet/List/Map/etc. to avoid this vulnerability.
Bug kind and pattern: MS - MS_MUTABLE_COLLECTION_PKGPROTECT
Change-Id: I68f8bc4aa3f99f6f504a5845ebbe5d0574291ace
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ConsolesBase.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Passed CI tests
Alexander Wels: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/46546
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I68f8bc4aa3f99f6f504a5845ebbe5d0574291ace
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org