Change in ovirt-engine[ovirt-engine-4.0]: webadmin: Look for sound device by general type
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Look for sound device by general type
......................................................................
webadmin: Look for sound device by general type
The sound device in the managed device map of a VM must be located by
VmDeviceGeneralType.SOUND, not by VmDeviceType.SOUND.
The code that was fixed in
InstanceTypeManager.postDoUpdateManagedFieldsFrom(VmBase) is called when
user edits a VM and NEXT_RUN snapshot exists. After getting the
information about NEXT_RUN snapshot, UI controls in the dialog are
updated accordingly. The "Sound card" checkbox is always unchecked,
because the code looks for a sound device incorrectly and cannot find
it. When user clicks "OK" in the dialog, the difference between actual
sound device configuration and the checkbox state is detected and
confirmation dialog is displayed.
Change-Id: I179bb4623815a90b5468e25e3432351e5458e04a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1356568
Signed-off-by: Shmuel Melamud <smelamud(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/VmDeviceCommonUtils.java
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Shmuel Leib Melamud: Verified
Arik Hadas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/63293
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I179bb4623815a90b5468e25e3432351e5458e04a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-4.0
Gerrit-Owner: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shmuel Leib Melamud <smelamud(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>