12:20 p.m.
Tal Nisan has submitted this change and it was merged.
Change subject: uicommonweb: Attach virtual IDE disks new behavior
......................................................................
uicommonweb: Attach virtual IDE disks new behavior
When a user tries to hot plug an IDE disk, he gets an error message
after the operation completes, telling him that an IDE disk cannot be
hot plugged. However, the disk is also not attached to the VM.
This patch introduces a new approach:
If the "Activate" check box is checked, a warning is shown if at least
one IDE disk is selected from the Images/LUNs list. The warning tells
the user that the disk will be attached but not activated, and that he
should activate manually after the VM is shut down.
In addition, a new tooltip was added to the "Activate" check box,
explaining that only non IDE disks are activated after attached.
Change-Id: I187c74c7c39f438dfa5e81942f4a6aec41323830
Bug-Url: https://bugzilla.redhat.com/1167248
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.java
M
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskAttachPopupWidget.ui.xml
M
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/AttachDiskModel.java
M
frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java
M
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/vm/BaseVmDiskAttachPopupView.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/BaseVmDiskAttachPopupView.java
7 files changed, 155 insertions(+), 19 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/38663
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I187c74c7c39f438dfa5e81942f4a6aec41323830
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org