Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy package ...................................................................... bootstrap: rewrite bootstrap using the new ovirt-host-deploy package CURRENT IMPLEMENTATION Host bootstrap is done via full blown bootstrap process via the legacy vds_bootstrap project. It executes the vds_bootstrap scripts twice one for 99% of the setup, then issue certificate and then again for 1% of the setup. Node bootstrap is done via short circuit between the vds_bootstrap project, which at the very start checks if the host is a node and if it is configure and restart vdsm_reg with one time password for it to register into engine. [I have never seen this OTP registration working]. Node approval uses the vdsm_reg's vdsm-gen-cert, vdsm-complete scripts in order to generate keys, and vdsm-complete to configure vdsm and restart. PROBLEM IN CURRENT IMPLEMENTATION *** COMPLETXITY!!!! *** Design and actual implementation. MISSION Retire VdsInstaller, OVirtInstaller implementations. NEW IMPLEMENTATION Use the new vdsm-bootstrap package that is dialog based. Changes includes: 1. Same sequence for both host and ovirt-node bootstrap, not using vdsm-reg, always run the same bootstrap process, while the bootstrap is node aware. 2. vdsm-bootstrap log download. 3. vdsm-id is acquired from the dialog, engine should not know how vdsm-id is generated, nor assume it can perform this remotely. 4. Much more freedom for the host side, it detects the host type (host/node), it decides if reboot is required and finally it decides if there was an error. 5. Use python tar implementation instead of system tar, as fedora-18 vanilla has no tar installed. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: If78c62601231f4729ca95da7653907b37856d672 Signed-off-by: Alon Bar-Lev <alonbl@redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtInstaller.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/utils/pom.xml D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/HostKeyVerifier.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/IVdsInstallerCallback.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java D backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/DefaultValuesConfigUtil.java D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java M backend/manager/tools/engine-config/src/main/resources/engine-config.properties M packaging/fedora/spec/ovirt-engine.spec.in M pom.xml 16 files changed, 1,175 insertions(+), 2,141 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9175 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If78c62601231f4729ca95da7653907b37856d672 Gerrit-PatchSet: 19 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl@redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland@redhat.com> Gerrit-Reviewer: Eli Mesika <emesika@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>