Change in ovirt-engine[ovirt-engine-3.5.2]: webadmin: REST API login popup
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: REST API login popup
......................................................................
webadmin: REST API login popup
- The REST API login popup would appear when one of the following was true:
1 The engine session hard limit was reached (10 hours) and the REST API
ping would happen before a refresh that would cause a logout.
2 The REST API ping would not happen due to it detecting that the refresh
flag was not set, however the engine would internally set the refresh
on a sub query. This causes the REST api http session to expire and on
a sub sequent ping would cause the popup to appear.
- This patch fixes 1. We take the hard limit into account and if we are close
enough to the hard limit the REST API ping is disabled causing the natural
logout of the webadmin UI to happen.
Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1206908
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServlet.java
M
frontend/webadmin/modules/frontend/src/test/java/org/ovirt/engine/ui/frontend/server/gwt/WebAdminHostPageServletTest.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/EngineSessionTimeoutData.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/restapi/RestApiSessionManager.java
M
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
5 files changed, 53 insertions(+), 16 deletions(-)
Approvals:
Alexander Wels: Verified
Greg Sheremeta: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/39421
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia09a6495268cacbb47019e3207a63c66205e9e03
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.5.2
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org