Change in ovirt-engine[master]: core: EnumUtils - used cached map if available
Allon Mureinik has submitted this change and it was merged.
Change subject: core: EnumUtils - used cached map if available
......................................................................
core: EnumUtils - used cached map if available
Reuse the cached version of the uppercase map in EnumUtils if it already
existed.
This has two slight benefits:
1. Better memory management, by making sure we're reusing the same
references all over.
2. It solves the normal priority FindBugs
RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED warning on this issue.
Change-Id: I486a09d190a2c02be666400c59795e7104f83d79
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/EnumUtils.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13231
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I486a09d190a2c02be666400c59795e7104f83d79
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>