Laszlo Hornyak has submitted this change and it was merged. Change subject: core: Cleanup in AuditLogableBase ...................................................................... core: Cleanup in AuditLogableBase Did some general java cleanups: * Added final to immutable members * Removed dependency on the deprecated StringHelper, replaced with commons lang's StringUtils * Replaced FQCNs with imports * Unwrapped some if {return XXX} else {return YYYY} clauses Change-Id: I78cb09b8fe4e607c696a8ded8432604bb95d9fa2 Signed-off-by: Allon Mureinik <amureini@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 1 file changed, 12 insertions(+), 15 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5863 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78cb09b8fe4e607c696a8ded8432604bb95d9fa2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini@redhat.com> Gerrit-Reviewer: Daniel Erez <derez@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs@redhat.com>